fix(nix): expose ripgrep and fd to wrapped kimi - #428
Merged
Conversation
- make wrapper available to the Nix build - wrap kimi binary with ripgrep and fd on PATH - include rg and fd in the dev shell packages
🦋 Changeset detectedLatest commit: 4098c85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the Nix-packaged CLI wrapper so
ripgrepandfdare available onPATH, and include both tools in the Nix dev shell for local development.1. Expose search tools in Nix builds
Problem: Nix-built
kimibinaries could not findrg/fdat runtime, and the Nix dev shell did not provide these CLI search dependencies either.What was done:
makeWrapperto the Nix build inputs.$out/bin/kimiwithripgrepandfdonPATH.ripgrepandfdto the dev shell packages.Related Issue
No related issue; the problem is described above.
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.